[0.15.1.0] Sustained notes remain sustained after getting off piano

Bug Report
1

If you’re on piano and then get off of it, notes will stay sustained if you don’t let off of them.

Steps to Reproduce

Got on a piano and press some keys down and then get off/stash it (without lifting the keys).

What I expected to happen

If you get off of the piano (or it’s deleted) that it would release any held down/sustained keys/notes. I don’t expect it to stop immediately or abruptly cut off, but to fade out the same way it would if you just let go of the key.

What happened

They stayed held down. It is also susceptible to desync, so they might not be held down for you but may be for others.

Notes / Media

Not really much of an inconvenience now as the piano sound fades out, but if any of the new sounds planned are able to be sustained for longer (or like- indefinitely), this could be an issue because it’s one thing if someone’s actively and purposefully spamming notes, it’s another if it’s an accidental thing and now others just have a bunch of random noises coming from seemingly nowhere.

Exiting piano while keys pressed (can see the depressed keys)

Having piano deleted while keys are being pressed

3 Likes
2

Thank you. I made it so all sounds are ended when the item is removed, and when the player leaves it. Keys will also lift when released while sustained. This will take effect with the next update.

3 Likes
3

Not sure if it was a change of heart or if it’s a bug, but on the Electronic Keyboard there’s a bit of hum after you get off the instrument now as opposed to the hard cutoff it used to have. The Piano, Drumkit, and Bongos all still have the hard cutoff.

1 Like
4

That’s a bug. Some debug sound logic accidentally got shipped with the last update, but the next update fixes it. I hoped no one would notice it :upside_down_face:

2 Likes